Add Kafka backend#453
Closed
QuentinRillet wants to merge 2 commits intocodingjoe:mainfrom
Closed
Conversation
QuentinRillet
force-pushed
the
feat_add_kafka_healthcheck
branch
from
ca160e7 to
5f2475f
Compare
QuentinRillet
changed the title
QuentinRillet
force-pushed
the
feat_add_kafka_healthcheck
branch
from
5f2475f to
aadb1da
Compare
QuentinRillet
force-pushed
the
feat_add_kafka_healthcheck
branch
from
aadb1da to
69fb1f5
Compare
QuentinRillet
changed the title
codingjoe
reviewed
Dec 19, 2025
Owner
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
Hi @QuentinRillet 👋,
Thank you for your contribution. I don't mind mainline Kafka support. However, your patch still needs to go some way before it can be merged. Mainly tests, preferably actually having Kafka run on CI? I don't like the idea of patching the entire API.
Please also add documentation and an extra section in the pyproject.toml
Cheers!
Joe
Comment on lines
+1
to
+4
| import django | ||
|
|
||
| if django.VERSION < (3, 2): | ||
| default_app_config = "health_check.contrib.kafka.apps.HealthCheckConfig" |
Owner
There was a problem hiding this comment.
Django 3.2 has reached end of life 😉
Closed
Owner
|
Closed in favor of #564 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Kafka Health Check Backend
This pull request introduces a new [KafkaHealthCheck backend to the project. The health check verifies the connectivity and availability of a Kafka broker by:
Notes:
Requires kafka-python or kafka-python-ng to be installed.
Includes error handling for missing libraries or invalid configurations.
This addition enhances the monitoring capabilities of the project by providing support for Kafka-based systems.